-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement EFI host creation #134
base: master
Are you sure you want to change the base?
Conversation
9167c0d
to
56b0b8f
Compare
I really don't like the RuboCop style rules that are set up ... |
This implements EFI host creation by specifying the os_firmware attribute to be efi. It's also possible to set the os_loader attribute to secure (for UEFI secure boot) or stateless (for AMD SEV). Both secure and stateless imply the os_firmware to be efi.
What is needed to move forward with this? I would like to start using efi for pxebooting libvirt VMs via foreman. |
type = xml.type(os_type, :arch => arch) | ||
type[:machine] = "q35" if ["i686", "x86_64"].include?(arch) | ||
|
||
# TODO: can you use both secure and stateless at the same time? | ||
case attributes[:os_loader] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: https://libvirt.org/kbase/secureboot.html says the os_loader was only needed for libvirt >= 7.2 < 8.6
This implements EFI host creation by specifying the os_firmware attribute to be efi. It's also possible to set the os_loader attribute to secure (for UEFI secure boot) or stateless (for AMD SEV). Both secure and stateless imply the os_firmware to be efi.
It includes #132 because the secure boot loader creates NVRAM and otherwise you wouldn't be able to delete those machines.
Only minimal testing on Fedora 38 has been done, but I can create VMs and have them boot up.
Fixes #128